Skip to content

fix(FormApi): clear onMount validation errors #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

bpinto
Copy link

@bpinto bpinto commented May 15, 2025

Fix #1510

@bpinto
Copy link
Author

bpinto commented May 15, 2025

I'm thinking that instead of this change that maybe it would be expected to add a validators={{ onChangeListenTo: ['aOrB'] }} to both a and b fields.

@bpinto bpinto force-pushed the clear-onmount-validation branch 2 times, most recently from 303d1fb to 46355d2 Compare May 15, 2025 15:53
Clear the `onMount` validation errors when the next validation is
performed.
Copy link

nx-cloud bot commented May 26, 2025

View your CI Pipeline Execution ↗ for commit 2f35e8e.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 8s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-26 20:03:01 UTC

@@ -7,7 +7,7 @@ title: TanStackField

# Class: TanStackField\<TParentData, TName, TData, TOnMount, TOnChange, TOnChangeAsync, TOnBlur, TOnBlurAsync, TOnSubmit, TOnSubmitAsync, TFormOnMount, TFormOnChange, TFormOnChangeAsync, TFormOnBlur, TFormOnBlurAsync, TFormOnSubmit, TFormOnSubmitAsync, TFormOnServer, TSubmitMeta\>

Defined in: [tanstack-field.directive.ts:31](https://github.com/TanStack/form/blob/main/packages/angular-form/src/tanstack-field.directive.ts#L31)
Defined in: [tanstack-field.directive.ts:31](https://github.com/Pascalmh/tanstack-form/blob/main/packages/angular-form/src/tanstack-field.directive.ts#L31)
Copy link
Contributor

@LeCarbonator LeCarbonator May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, the docs seem to be messed up ... hopefully that gets fixed after merging

@bpinto
Copy link
Author

bpinto commented Jun 10, 2025

I'm going to close this since I believe this issue will be handled by one of the maintainers soon, and additionally I don't believe this is the right fix anymore. 😅

@bpinto bpinto closed this Jun 10, 2025
@bpinto bpinto deleted the clear-onmount-validation branch June 10, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants